docs(skill): flag that Ready phase isn't necessarily healthy#63
Merged
Conversation
A Ready replica can have a stale Active restore and a growing consecutiveRestoreFailures counter — every recent restore attempt has failed, so its data is older than lastRestoreCompletedAt suggests. To users "the replica isn't working" usually means stale data, not refused connections. Note this in the pgro-status skill's overview checks so future agents cross-reference the failure counter against the last successful restore before declaring a Ready replica healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Adds a note to the `pgro-status` skill's Phase 1 overview that a replica in `Ready` phase isn't automatically healthy: `Ready` only means the operator's switchover state machine is at rest, not that data is fresh. A replica with `consecutiveRestoreFailures > 0` and growing is serving increasingly stale data even though its phase looks fine.
This came out of a recent incident where I reported "the dev replicas are healthy" based on Phase column alone, missing that they hadn't had a successful restore in 28–38h. To users, "the replica isn't working" usually means stale data, not refused connections — so the skill should explicitly tell future agents to cross-check the failure counter against `lastRestoreCompletedAt` and the schedule.